refactor: Improve error when submitting block #2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangsoledad
previously approved these changes
Jul 15, 2020
yangby-cryptape
previously approved these changes
Jul 16, 2020
doitian
dismissed stale reviews from yangby-cryptape and zhangsoledad
via
324b5c9
|
Rebased to resolve conflicts in verification/src/error.rs |
yangby-cryptape
approved these changes
Jul 22, 2020
quake
previously approved these changes
Jul 31, 2020
CKB - Pull Requests
automation
moved this from 👀 Awaiting review
to ✅ Reviewer approved
Jul 31, 2020
|
bors r=quake,yangby-cryptape |
bors bot
added a commit
that referenced
this pull request
Jul 31, 2020
2168: refactor: Improve error when submitting block r=quake,yangby-cryptape a=doitian Include more info in the error messages: * Add expected version and actual value in header version error. Add logs to ease debugging PoW. It can be enabled by setting the log level: ``` [logger] filter = "info,ckb-pow=debug" ``` Co-authored-by: ian <ian@nervos.org>
|
Build failed: |
yangby-cryptape
requested changes
Jul 31, 2020
CKB - Pull Requests
automation
moved this from ✅ Reviewer approved
to 👀 Awaiting review
Jul 31, 2020
Add expected version and the actual value in the error message.
The log can be enabled by setting the log level of target "ckb-pow" to debug. Example ``` [logger] filter = "info,ckb-pow=debug" ``` The error message of the error `PowError::InvalidNonce` is also changed to include a hint: ``` InvalidNonce: please set logger.filter to "info,ckb-pow=debug" to see detailed PoW verification information in the log" ```
|
Resolved the Cargo.lock conflict |
quake
approved these changes
Aug 5, 2020
keroro520
approved these changes
Aug 6, 2020
yangby-cryptape
approved these changes
Aug 6, 2020
|
bors r=quake,keroro520,yangby-cryptape |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include more info in the error messages:
Add logs to ease debugging PoW. It can be enabled by setting the log level: