Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add clear_banned_addresses rpc #2259

Merged
merged 1 commit into from
Sep 24, 2020
Merged

feat: add clear_banned_addresses rpc #2259

merged 1 commit into from
Sep 24, 2020

Conversation

quake
Copy link
Member

@quake quake commented Sep 4, 2020

No description provided.

@quake quake requested a review from a team September 4, 2020 06:53
@quake quake requested a review from a team as a code owner September 4, 2020 06:53
@keroro520
Copy link
Contributor

clear_banned_addresses, get_banned_addresses and set_ban use different naming grammer.
As a personal taste, I like clear_banned.

@quake
Copy link
Member Author

quake commented Sep 24, 2020

bors r=keroro520,zhangsoledad

bors bot added a commit that referenced this pull request Sep 24, 2020
@bors @quake
Merge #2259
269d04a 
2259: feat: add clear_banned_addresses rpc r=keroro520,zhangsoledad a=quake



Co-authored-by: quake <quake.wang@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 24, 2020

Build failed:

  • continuous-integration/travis-ci/push

@quake
Copy link
Member Author

quake commented Sep 24, 2020

bors retry

@bors
Copy link
Contributor

bors bot commented Sep 24, 2020

Build succeeded:

@bors bors bot merged commit e7ce25a into develop Sep 24, 2020
@bors bors bot deleted the quake/clear-ban-rpc branch September 24, 2020 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keroro520 keroro520 keroro520 approved these changes

@zhangsoledad zhangsoledad zhangsoledad approved these changes

@doitian doitian Awaiting requested review from doitian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@quake @keroro520 @zhangsoledad