feat(test): redesign the way of Net communicate with peers #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keroro520
force-pushed
the
integration-test-programability-net
branch
from
0c20743
to
4de276f
Compare
quake
reviewed
Sep 25, 2020
quake
previously approved these changes
Sep 27, 2020
keroro520
force-pushed
the
integration-test-programability-net
branch
from
4de276f
to
bbb6a4e
Compare
quake
approved these changes
Sep 28, 2020
ybian19
approved these changes
Sep 30, 2020
|
bors r=quake,chuijiaolianying |
bors bot
added a commit
that referenced
this pull request
Sep 30, 2020
2294: feat(test): redesign the way of Net communicate with peers r=quake,chuijiaolianying a=keroro520 Based on #2286. So please review #2286 first. There are 2 significant updations: * Initialize `Net`'s network controller when creating `Net` Instance. * Make the communication channels peer-level. Which is say, we can receive network messages from specific peers. This feature prevents peers' message confusion. Co-authored-by: keroro <keroroxx520@gmail.com>
|
Build failed:
|
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Oct 9, 2020
2294: feat(test): redesign the way of Net communicate with peers r=quake,chuijiaolianying a=keroro520 Based on #2286. So please review #2286 first. There are 2 significant updations: * Initialize `Net`'s network controller when creating `Net` Instance. * Make the communication channels peer-level. Which is say, we can receive network messages from specific peers. This feature prevents peers' message confusion. Co-authored-by: keroro <keroroxx520@gmail.com>
|
Timed out. |
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2286. So please review #2286 first.
There are 2 significant updations:
Net's network controller when creatingNetInstance.