Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: skip RUSTSEC-2020-0043 temporarily #2298

Conversation

yangby-cryptape
Copy link
Collaborator

@yangby-cryptape yangby-cryptape commented Sep 27, 2020

ws allows remote attacker to run the process out of memory.
Since it is no longer actively maintained, we couldn't fix it in the short term, skip it temporarily to avoid blocking other PRs.

p.s. That issue was reported before one year, but there is still no reply.

@quake
Copy link
Member

quake commented Sep 27, 2020

bors r=quake,zhangsoledad

bors bot added a commit that referenced this pull request Sep 27, 2020
2298: ci: skip RUSTSEC-2020-0043 temporarily r=quake,zhangsoledad a=yangby-cryptape

[`ws` allows remote attacker to run the process out of memory.](https://rustsec.org/advisories/RUSTSEC-2020-0043)
Since it is no longer actively maintained, we couldn't fix it in the short term, skip it temporarily to avoid blocking other PRs.

p.s. That issue was reported before one year, but there is still no reply.

Co-authored-by: Boyu Yang <yangby@cryptape.com>
@yangby-cryptape
Copy link
Collaborator Author

Failed to merge by bors because "Waiting on code owner review from @doitian."

@doitian
Copy link
Member

doitian commented Sep 28, 2020

bors retry

@bors
Copy link
Contributor

bors bot commented Sep 28, 2020

Build succeeded:

  • continuous-integration/travis-ci/push

@bors bors bot merged commit f23d32a into nervosnetwork:develop Sep 28, 2020
@yangby-cryptape yangby-cryptape deleted the pr/skip-RUSTSEC-2020-0043-temporarily branch October 15, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants