Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide --overwrite-spec to override the chain spec in storage #2505

Merged
merged 1 commit into from Jan 27, 2021

Conversation

keroro520
Copy link
Contributor

@keroro520 keroro520 commented Jan 11, 2021

Ckb stores chain spec into the database and compare the configured chain spec on starting.

A user may want to overwrite the stored chain spec when it changes the configured chain spec and makes sure the change is acceptable. Therefore this PR adds --overwrite-spec command option to overwrite the stored chain spec.


  • If you want to just skip the chain spec checking without overriding the stored one:

    ckb run --skip-spec-check ...
  • If you want to overwrite the stored chain spec with the configured one:

    ckb run --overwrite-spec ...

@keroro520 keroro520 requested a review from a team January 11, 2021 06:44
@keroro520 keroro520 requested a review from a team January 11, 2021 06:44
quake
quake previously approved these changes Jan 15, 2021
@yangby-cryptape yangby-cryptape changed the title feat: provide --override-spec to override the chain spec in storage feat: provide --overwrite-spec to override the chain spec in storage Jan 15, 2021
@quake
Copy link
Member

quake commented Jan 27, 2021

bors r=quake,yangby-cryptape

@bors
Copy link
Contributor

bors bot commented Jan 27, 2021

Build succeeded:

@bors bors bot merged commit b031268 into nervosnetwork:develop Jan 27, 2021
bors bot added a commit that referenced this pull request Nov 26, 2021
3198: chore: upgrade deps r=zhangsoledad,yangby-cryptape a=driftluo

### What problem does this PR solve?

ipnetwork 0.14 -> 0.18

There is no security fix, only partially optimized code

achanda/ipnetwork@v0.14.0...v0.18.0

futures 0.3.12 -> 0.3.18
```
# 0.3.18 - 2021-11-23

* Fix unusable `Sink` implementation on `stream::Scan` (#2499)
* Make `task::noop_waker_ref` available without `std` feature (#2505)
* Add async `LineWriter` (#2477)
* Remove dependency on `proc-macro-hack`. This raises MSRV of utility crates to 1.45. (#2520)

# 0.3.17 - 2021-08-30

* Use `FuturesOrdered` in `join_all` (#2412)
* Add `{future, stream}::poll_immediate` (#2452)
* Add `stream_select!` macro (#2262)
* Implement `Default` for `OptionFuture` (#2471)
* Add `Peekable::{peek_mut, poll_peek_mut}` (#2488)
* Add `BufReader::seek_relative` (#2489)

# 0.3.16 - 2021-07-23

* Add `TryStreamExt::try_chunks` (#2438)
* Add `StreamExt::{all, any}` (#2460)
* Add `stream::select_with_strategy` (#2450)
* Update to new `io_slice_advance` interface (#2454)

# 0.3.15 - 2021-05-11

* Use `#[proc_macro]` at Rust 1.45+ to fix an issue where proc macros don't work with rust-analyzer (#2407)
* Support targets that do not have atomic CAS on stable Rust (#2400)
* futures-test: Add async `#[test]` function attribute (#2409)
* Add `stream::abortable` (#2410)
* Add `FuturesUnordered::clear` (#2415)
* Implement `IntoIterator` for `FuturesUnordered` (#2423)
* Implement `Send` and `Sync` for `FuturesUnordered` iterators (#2416)
* Make `FuturesUnordered::iter_pin_ref` public (#2423)
* Add `SelectAll::clear` (#2430)
* Add `SelectAll::{iter, iter_mut}` (#2428)
* Implement `IntoIterator` for `SelectAll` (#2428)
* Implement `Clone` for `WeakShared` (#2396)

# 0.3.14 - 2021-04-10

* Add `future::SelectAll::into_inner` (#2363)
* Allow calling `UnboundedReceiver::try_next` after `None` (#2369)
* Reexport non-Ext traits from the root of `futures_util` (#2377)
* Add `AsyncSeekExt::stream_position` (#2380)
* Add `stream::Peekable::{next_if, next_if_eq}` (#2379)

# 0.3.13 - 2021-02-23

* Mitigated starvation issues in `FuturesUnordered` (#2333)
* Fixed race with dropping `mpsc::Receiver` (#2304)
* Added `Shared::{strong_count, weak_count}` (#2346)
* Added `no_std` support for `task::noop_waker_ref` (#2332)
* Implemented `Stream::size_hint` for `Either` (#2325)
```

### Check List

Tests

- Unit test
- Integration test

### Release note

```release-note
None: Exclude this PR from the release note.
```



Co-authored-by: driftluo <driftluo@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants