Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve peer store dump issue #2556

Merged
merged 1 commit into from
Feb 10, 2021
Merged

fix: resolve peer store dump issue #2556

merged 1 commit into from
Feb 10, 2021

Conversation

quake
Copy link
Member

@quake quake commented Feb 7, 2021

No description provided.

@quake quake requested a review from a team February 7, 2021 07:30
@quake quake force-pushed the quake/fix-peerstore-dump-flush branch from 15b47e1 to b7c354b Compare February 7, 2021 07:32
doitian
doitian previously approved these changes Feb 7, 2021
View reviewed changes
zhangsoledad
zhangsoledad previously approved these changes Feb 7, 2021
View reviewed changes
@quake quake dismissed stale reviews from zhangsoledad and doitian via a7e313c February 7, 2021 08:24
@quake quake force-pushed the quake/fix-peerstore-dump-flush branch from b7c354b to a7e313c Compare February 7, 2021 08:24
driftluo
driftluo previously approved these changes Feb 8, 2021
View reviewed changes
@quake quake force-pushed the quake/fix-peerstore-dump-flush branch from a7e313c to ab112f7 Compare February 8, 2021 08:54
@quake
Copy link
Member Author

quake commented Feb 8, 2021

rebased with develop branch to resolve deny.toml issue, please review again, thanks

doitian
doitian previously approved these changes Feb 8, 2021
View reviewed changes
@quake quake force-pushed the quake/fix-peerstore-dump-flush branch from ab112f7 to a3abb4a Compare February 8, 2021 23:09
@quake quake force-pushed the quake/fix-peerstore-dump-flush branch from a3abb4a to d0d71e2 Compare February 8, 2021 23:11
@doitian doitian added this to 😴 Awaiting Review in CKB - Pull Requests Feb 9, 2021
@doitian doitian moved this from 😴 Awaiting Review to 👀 In review (Max 4) in CKB - Pull Requests Feb 10, 2021
CKB - Pull Requests automation moved this from 👀 In review (Max 4) to ✅ Reviewer approved Feb 10, 2021
@doitian
Copy link
Member

doitian commented Feb 10, 2021

bors r=doitian,driftluo

@bors
Copy link
Contributor

bors bot commented Feb 10, 2021

Build succeeded:

@bors bors bot merged commit f9f5e43 into develop Feb 10, 2021
CKB - Pull Requests automation moved this from ✅ Reviewer approved to Done Feb 10, 2021
@bors bors bot deleted the quake/fix-peerstore-dump-flush branch February 10, 2021 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doitian doitian doitian approved these changes

@driftluo driftluo driftluo approved these changes

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad

Assignees
No one assigned
Labels
None yet
Projects
CKB - Pull Requests
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@quake @doitian @zhangsoledad @driftluo