chore: add EpochProvider trait and refactor dao calculation #2594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quake
requested review from
doitian,
keroro520,
yangby-cryptape and
zhangsoledad
as code owners
quake
force-pushed
the
quake/refactor-trait-dao-related
branch
from
781cfff
to
545b86c
Compare
doitian
approved these changes
Mar 5, 2021
CKB - Pull Requests
automation
moved this from 👀 In review (Max 4)
to ✅ Reviewer approved
Mar 5, 2021
zhangsoledad
approved these changes
Mar 5, 2021
|
bors r=doitian,zhangsoledad |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added a
EpochProvidertrait and refactor dao calculation related code, eliminated theutil/daocrate's store dependency.benchmark
next_epoch_extwas deleted because it is benchmarking the performance of getting the same epoch information, I think it is unnecessary and meaningless.