Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readonly for migrate check #2629

Merged
merged 2 commits into from
Mar 25, 2021
Merged

readonly for migrate check #2629

merged 2 commits into from
Mar 25, 2021

Conversation

zhangsoledad
Copy link
Member

@zhangsoledad zhangsoledad commented Mar 24, 2021 •
edited

  • Perform migration check with read-only mode to prevent automatically create columns breaking compatibility
  • Fix the error message is displayed incorrectly while performing the migration
    Run error: Error { kind: Spec, inner: GenesisMismatch(...

@zhangsoledad zhangsoledad requested a review from a team March 24, 2021 13:24
@zhangsoledad zhangsoledad changed the title readonly for migrate check [HOLD] readonly for migrate check Mar 25, 2021
@zhangsoledad zhangsoledad changed the title [HOLD] readonly for migrate check readonly for migrate check Mar 25, 2021
@zhangsoledad
Copy link
Member Author

bors r=quake,yangby-cryptape

@bors
Copy link
Contributor

bors bot commented Mar 25, 2021

Build succeeded:

@bors bors bot merged commit ff1fc99 into nervosnetwork:develop Mar 25, 2021
@zhangsoledad zhangsoledad deleted the zhangsoledad/fix-migrate branch March 25, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

@yangby-cryptape yangby-cryptape yangby-cryptape approved these changes

@doitian doitian Awaiting requested review from doitian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhangsoledad @quake @yangby-cryptape