Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hardfork): remove the header deps immature rule #2798

Merged
merged 2 commits into from
Jul 5, 2021
Merged

feat(hardfork): remove the header deps immature rule #2798

merged 2 commits into from
Jul 5, 2021

Conversation

yangby-cryptape
Copy link
Collaborator

@yangby-cryptape yangby-cryptape commented Jul 1, 2021 •
edited
Loading

Changes

@yangby-cryptape yangby-cryptape added the u:ckb2021 Upgrade: Fork ckb2021 label Jul 1, 2021
@yangby-cryptape yangby-cryptape marked this pull request as ready for review July 2, 2021 02:35
@yangby-cryptape yangby-cryptape requested a review from a team July 2, 2021 02:35
@yangby-cryptape yangby-cryptape requested a review from a team as a code owner July 2, 2021 02:35
@yangby-cryptape yangby-cryptape added the s:waiting-on-reviewers Status: Waiting for Review label Jul 2, 2021
doitian
doitian reviewed Jul 2, 2021
View reviewed changes
util/types/src/core/cell.rs Outdated Show resolved Hide resolved
@yangby-cryptape yangby-cryptape added s:hold Status: Put this issue on hold. s:waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed s:waiting-on-reviewers Status: Waiting for Review labels Jul 2, 2021
@yangby-cryptape yangby-cryptape force-pushed the pr/remove-header-deps-immature-rule branch from 4bf4a9c to d12fcb3 Compare July 2, 2021 08:57
@yangby-cryptape yangby-cryptape force-pushed the pr/remove-header-deps-immature-rule branch from d12fcb3 to a205c0b Compare July 2, 2021 10:06
@yangby-cryptape yangby-cryptape added s:waiting-on-reviewers Status: Waiting for Review and removed s:hold Status: Put this issue on hold. s:waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. labels Jul 2, 2021
@yangby-cryptape
Copy link
Collaborator Author

bors r=quake,driftluo

@yangby-cryptape yangby-cryptape removed the s:waiting-on-reviewers Status: Waiting for Review label Jul 5, 2021
@bors
Copy link
Contributor

bors bot commented Jul 5, 2021

Build succeeded:

@bors bors bot merged commit 05ff930 into nervosnetwork:develop Jul 5, 2021
@yangby-cryptape yangby-cryptape deleted the pr/remove-header-deps-immature-rule branch July 5, 2021 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

@driftluo driftluo driftluo approved these changes

@keroro520 keroro520 Awaiting requested review from keroro520

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad

@doitian doitian Awaiting requested review from doitian

Assignees
No one assigned
Labels
u:ckb2021 Upgrade: Fork ckb2021
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yangby-cryptape @quake @doitian @driftluo