Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace p2p library #295

Merged
merged 20 commits into from
Mar 14, 2019
Merged

Replace p2p library #295

merged 20 commits into from
Mar 14, 2019

Conversation

jjyr
Copy link
Contributor

@jjyr jjyr commented Mar 1, 2019

No description provided.

@jjyr jjyr added the t:enhancement Type: Feature, refactoring. label Mar 1, 2019
@jjyr jjyr changed the title Replace p2p library [WIP]Replace p2p library Mar 1, 2019
@jjyr jjyr force-pushed the replace-p2p-library branch 2 times, most recently from 814d199 to 9d183f0 Compare March 4, 2019 02:42
@jjyr jjyr changed the title [WIP]Replace p2p library Replace p2p library Mar 11, 2019
@jjyr jjyr force-pushed the replace-p2p-library branch 3 times, most recently from e26b894 to 9cd7618 Compare March 12, 2019 07:54
@driftluo
Copy link
Collaborator

driftluo commented Mar 12, 2019

This pr has the same problem as cita's pr.

Doesn't notice the definition of name/support_version. Used the default definition, which is /p2p/{protocol_id}.

In fact, the protocol id is just an internal index, so there is no need to expose it externally. The same protocol for each service can be implemented internally as a different id

network/src/network.rs Show resolved Hide resolved
network/src/network.rs Outdated Show resolved Hide resolved
@quake
Copy link
Member

quake commented Mar 12, 2019

This PR breaks integration test, could you help to debug?

make build
cd test
cargo run

error

thread 'main' panicked at 'assertion failed: node0.rpc_client().get_block(hash.clone()).call().unwrap().is_some()', test/src/specs/block_relay.rs:20:9

it looks like node cannot connect to peers.

@jjyr
Copy link
Contributor Author

jjyr commented Mar 14, 2019

This PR breaks integration test, could you help to debug?

make build
cd test
cargo run

error

thread 'main' panicked at 'assertion failed: node0.rpc_client().get_block(hash.clone()).call().unwrap().is_some()', test/src/specs/block_relay.rs:20:9

it looks like node cannot connect to peers.

Fixed in last commit.

@jjyr jjyr merged commit 0d980de into nervosnetwork:develop Mar 14, 2019
@jjyr jjyr deleted the replace-p2p-library branch March 14, 2019 06:34
@doitian doitian mentioned this pull request Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:enhancement Type: Feature, refactoring.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants