Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test for net #3007

Merged
merged 1 commit into from Sep 18, 2021
Merged

test: add test for net #3007

merged 1 commit into from Sep 18, 2021

Conversation

driftluo
Copy link
Collaborator

@driftluo driftluo commented Sep 3, 2021

What problem does this PR solve?

add more tests on the network

Check List

Tests

  • Unit test

Side effects

  • Improved network unit test coverage to 70%+

Release note

None: Exclude this PR from the release note.

@driftluo driftluo requested a review from a team as a code owner September 3, 2021 02:33
@driftluo driftluo force-pushed the add-test-on-net branch 3 times, most recently from 5ec4f3f to 0df0771 Compare September 3, 2021 02:50
chanhsu001
chanhsu001 approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@chanhsu001 chanhsu001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buddy, lot of code is testing, that'ok....but i will say, the whole pr contains small modifications in the code out of test code
i cannot confirm with that part(i'm not familiar with it), i hope it works.

@driftluo driftluo force-pushed the add-test-on-net branch 3 times, most recently from 9dffa80 to 17ecc6b Compare September 8, 2021 02:41
@driftluo driftluo force-pushed the add-test-on-net branch 2 times, most recently from a31135f to 36f8569 Compare September 16, 2021 07:03
@quake
Copy link
Member

quake commented Sep 18, 2021

bors r=quake,chanhsu001

@bors
Copy link
Contributor

bors bot commented Sep 18, 2021

Build succeeded:

@bors bors bot merged commit 5a28790 into nervosnetwork:develop Sep 18, 2021
@driftluo driftluo deleted the add-test-on-net branch September 18, 2021 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

@chanhsu001 chanhsu001 chanhsu001 approved these changes

@doitian doitian Awaiting requested review from doitian

@liya2017 liya2017 Awaiting requested review from liya2017

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@driftluo @quake @chanhsu001