Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve inflight proposals memory bloat issue #3093

Merged
merged 1 commit into from
Oct 19, 2021
Merged

fix: resolve inflight proposals memory bloat issue #3093

merged 1 commit into from
Oct 19, 2021

Conversation

quake
Copy link
Member

@quake quake commented Oct 14, 2021

What problem does this PR solve?

the inflight_proposals field of SyncState struct is never cleared.

What is changed and how it works?

change the inflight_proposals to map and clear expired data when processing the BlockProposals message.

Check List

Tests

  • Unit test

Release note 

Title Only: Include only the PR title in the release note.

@quake quake requested a review from a team as a code owner October 14, 2021 08:06
@quake quake force-pushed the quake/fix-inflight-proposals-memory-bloat branch from ffe7274 to 2686c1c Compare October 14, 2021 08:19
@quake
Copy link
Member Author

quake commented Oct 19, 2021

bors r=doitian,driftluo

@bors
Copy link
Contributor

bors bot commented Oct 19, 2021

Build succeeded:

@bors bors bot merged commit fb68319 into nervosnetwork:develop Oct 19, 2021
@quake quake deleted the quake/fix-inflight-proposals-memory-bloat branch March 20, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doitian doitian doitian approved these changes

@driftluo driftluo driftluo approved these changes

@keroro520 keroro520 Awaiting requested review from keroro520 keroro520 is a code owner automatically assigned from nervosnetwork/ckb-dev

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@quake @doitian @driftluo