fix: fix inflight block potential memory bloat issues #3094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quake
requested changes
Oct 15, 2021
driftluo
force-pushed
the
fix-inflight-block
branch
from
a3aac7c
to
0173fce
Compare
quake
approved these changes
Oct 18, 2021
keroro520
approved these changes
Oct 19, 2021
|
bors r=quake,keroro520 |
bors bot
added a commit
that referenced
this pull request
Oct 19, 2021
3094: fix: fix inflight block potential memory bloat issues r=quake,keroro520 a=driftluo ### What problem does this PR solve? `compact_reconstruct_inflight` only clear by `prune` on remote peer doesn't respond to the `GetBlockTransactions` requests, In most cases, the cleanup conditions are not established, which will cause memory bloat. This PR modified the internal implementation of the cleanup and added the corresponding test ### Check List Tests - Unit test ### Release note ```release-note Title Only: Include only the PR title in the release note. ``` Co-authored-by: driftluo <driftluo@foxmail.com>
|
Build failed: |
|
bors r=quake,keroro520 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
compact_reconstruct_inflightonly clear bypruneon remote peer doesn't respond to theGetBlockTransactionsrequests, In most cases, the cleanup conditions are not established, which will cause memory bloat.This PR modified the internal implementation of the cleanup and added the corresponding test
Check List
Tests
Release note