feat(rpc): add a method to remove a transaction from tx-pool #3170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanhsu001
reviewed
Nov 10, 2021
This RPC only provides a new operation, how to use this RPC based on people's imagination. There is no limit. |
quake
approved these changes
Nov 26, 2021
yangby-cryptape
force-pushed
the
pr/new-rpc
branch
from
a5d154f
to
f76a3a6
Compare
yangby-cryptape
added
s:waiting-on-author
zhangsoledad
approved these changes
Dec 1, 2021
|
bors r= quake,zhangsoledad |
bors bot
added a commit
that referenced
this pull request
Dec 5, 2021
3170: feat(rpc): add a method to remove a transaction from tx-pool r=quake,zhangsoledad a=yangby-cryptape ### What problem does this PR solve? If there are some transactions in tx pool, but we want to delete them, at present, the only way is to clear the whole tx pool. This PR add a new RPC to remove a transaction from tx pool via its hash. ### Check List Tests - Integration test ### Release note ```release-note Title Only: Include only the PR title in the release note. ``` Co-authored-by: Boyu Yang <yangby@cryptape.com>
|
Build failed: |
zhangsoledad
added
the
s:waiting-on-author
yangby-cryptape
added
s:blocked
|
bors r= quake,zhangsoledad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
If there are some transactions in tx pool, but we want to delete them, at present, the only way is to clear the whole tx pool.
This PR add a new RPC to remove a transaction from tx pool via its hash.
Check List
Tests
Release note