Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: genesis dep groups should supports relative file path #3343

Merged

Conversation

quake
Copy link
Member

@quake quake commented Mar 18, 2022

What problem does this PR solve?

When running ckb dev chain locally, user may put some custom scripts into the genesis block for development convenience, however, currently only system_cells supports relative paths, while dep_groups does not.

works:

[[genesis.system_cells]]
file = { file = "../compiled_binary/always_failure" }
create_type_id = true
capacity = 100_000_0000_0000

not working:

[[genesis.dep_groups]]
name = "always"
files = [
  { file = "../compiled_binary/always_success" },
  { file = "../compiled_binary/always_failure" },
]

this PR resolved this issue.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
./ckb init -c dev
edit dev.toml # add two script to dep_groups
mkdir compiled_binary
cp ckb/test/template/specs/cells/always_success compiled_binary
cp ckb/test/template/specs/cells/always_failure compiled_binary
./ckb run

Release note

Title Only: Include only the PR title in the release note.

@quake quake requested a review from a team as a code owner March 18, 2022 08:18
@quake quake requested review from zhangsoledad and removed request for a team March 18, 2022 08:18
@zhangsoledad
Copy link
Member

bors r+

@bors bors bot merged commit 0bc6db8 into nervosnetwork:develop Mar 21, 2022
@quake quake deleted the quake/fix-genesis-dep-groups-file-config branch March 20, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants