Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ckb cli) add h256 validator for --assume-valid-target and ba-code-hash #3345

Merged
merged 1 commit into from
Mar 23, 2022
Merged

fix(ckb cli) add h256 validator for --assume-valid-target and ba-code-hash #3345

merged 1 commit into from
Mar 23, 2022

Conversation

chanhsu001
Copy link
Contributor

fix(ckb cli) add h256 validator for --assume-valid-target and ba-code-hash

What problem does this PR solve?

  • add H256 validator for ckb init --ba-code-hash and ckb run --assume-valid-target replace naive is_hex check.
  • add related 1 testcase

What is changed and how it works?

now cli report error at parsing phase, prompt invalid h256 message, instead of running error.

Related changes

  • PR to update owner/repo:

Tests

  • Unit test
  • Integration test

Release note 

Title Only: Include only the PR title in the release note.

@chanhsu001 chanhsu001 requested a review from a team as a code owner March 21, 2022 14:29
@chanhsu001 chanhsu001 requested review from doitian and removed request for a team March 21, 2022 14:29
quake
quake requested changes Mar 22, 2022
View reviewed changes
util/app-config/src/cli.rs Outdated Show resolved Hide resolved
quake
quake reviewed Mar 22, 2022
View reviewed changes
util/app-config/src/cli.rs Outdated Show resolved Hide resolved
quake
quake reviewed Mar 22, 2022
View reviewed changes
util/app-config/src/cli.rs Outdated Show resolved Hide resolved
@doitian
Copy link
Member

doitian commented Mar 23, 2022

bors d=chanhsu001,quake

@bors
Copy link
Contributor

bors bot commented Mar 23, 2022

✌️ chanhsu001 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bors
Copy link
Contributor

bors bot commented Mar 23, 2022

✌️ quake can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@quake
Copy link
Member

quake commented Mar 23, 2022

bors r=quake

@bors
Copy link
Contributor

bors bot commented Mar 23, 2022

Build succeeded:

@bors bors bot merged commit bba8546 into nervosnetwork:develop Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangsoledad zhangsoledad zhangsoledad left review comments

@quake quake quake approved these changes

@doitian doitian Awaiting requested review from doitian doitian is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chanhsu001 @doitian @quake @zhangsoledad