Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove uncle cellbase #363

Closed
wants to merge 2 commits into from
Closed

remove uncle cellbase #363

wants to merge 2 commits into from

Conversation

zhangsoledad
Copy link
Member

@zhangsoledad zhangsoledad commented Mar 27, 2019 •
edited

  • update RFC#0019

doitian
doitian reviewed Mar 27, 2019
View reviewed changes
docs/data-structures.md Outdated Show resolved Hide resolved
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/remove_uncle_cellbase branch from 528e95e to eae8ef1 Compare March 29, 2019 03:24
@doitian
Copy link
Member

doitian commented Apr 8, 2019

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 8, 2019

👎 Rejected by too few approved reviews

@doitian
Copy link
Member

doitian commented Apr 8, 2019

bors retry

bors bot added a commit that referenced this pull request Apr 8, 2019
@bors @zhangsoledad
Merge #363
428a1e8 
363: remove uncle cellbase r=doitian a=zhangsoledad

- [ ] update RFC#0019 

Co-authored-by: zhangsoledad <787953403@qq.com>
@bors
Copy link
Contributor

bors bot commented Apr 8, 2019

Build failed

  • continuous-integration/travis-ci/push

@doitian
Copy link
Member

doitian commented Apr 8, 2019

Need to fix the merged generated flatbuffers file.

@doitian doitian added s:waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed s:waiting-for-bors labels Apr 8, 2019
@doitian
Copy link
Member

doitian commented Apr 8, 2019

Need to fix the merged generated flatbuffers file.

Regenerate verifier: #409

@doitian doitian closed this Apr 8, 2019
@zhangsoledad zhangsoledad deleted the zhangsoledad/remove_uncle_cellbase branch April 8, 2019 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake left review comments

@doitian doitian doitian approved these changes

Assignees
No one assigned
Labels
s:waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhangsoledad @doitian @quake