Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove block_filter_enable option #3665

Merged

Conversation

quake
Copy link
Member

@quake quake commented Oct 26, 2022

What problem does this PR solve?

Two configuration options (block_filter_enable and support_protocols) are conflicting, one is off by default and one is on by default

What is changed and how it works?

Remove the block_filter_enable option.

Check List

Tests

  • Unit test
  • Integration test

Release note

Title Only: Include only the PR title in the release note.

@quake quake requested a review from a team as a code owner October 26, 2022 23:42
@quake quake requested review from zhangsoledad and removed request for a team October 26, 2022 23:42
Copy link
Collaborator

@driftluo driftluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file needs to expose the support_protocols writeup(like rpc modules), now the user doesn't know how to change it.

Another question, do we need to turn off the filter protocol by default and let the user choose whether to turn it on or not?

@quake
Copy link
Member Author

quake commented Oct 27, 2022

I think this file needs to expose the support_protocols writeup(like rpc modules), now the user doesn't know how to change it.

added in the new commit, please review again, thanks.

Another question, do we need to turn off the filter protocol by default and let the user choose whether to turn it on or not?

I prefer turn on by default, this will result in more full nodes available to download the block filter for light client.

@zhangsoledad
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 27, 2022

@bors bors bot merged commit 13f2277 into nervosnetwork:develop Oct 27, 2022
@quake quake deleted the quake/remove-block_filter_enable-option branch March 20, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants