feat: fee-rate estimator #3783
Closed
feat: fee-rate estimator #3783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangsoledad
force-pushed
the
zhangsoledad/fee-rate-estimator
branch
8 times, most recently
from
98a6654
to
1feba63
Compare
zhangsoledad
force-pushed
the
zhangsoledad/fee-rate-estimator
branch
from
1feba63
to
4a90cbf
Compare
zhangsoledad
force-pushed
the
zhangsoledad/fee-rate-estimator
branch
from
4a90cbf
to
f4527f8
Compare
eval-exec
reviewed
Apr 5, 2023
eval-exec
reviewed
Apr 5, 2023
Comment on lines
+75
to
+82
| fn cmp(&self, other: &Self) -> ::std::cmp::Ordering { | ||
| let order = self.fee_rate.cmp(&other.fee_rate); | ||
| if order == ::std::cmp::Ordering::Equal { | ||
| other.weight.cmp(&self.weight) | ||
| } else { | ||
| order | ||
| } | ||
| } |
There was a problem hiding this comment.
How about this:
impl Ord for TxStatus {
fn cmp(&self, other: &Self) -> ::std::cmp::Ordering {
self.fee_rate
.cmp(&other.fee_rate)
.then_with(|| other.weight.cmp(&self.weight))
}
}
eval-exec
reviewed
Apr 6, 2023
| let fee_rate = FeeRate::calculate(Capacity::shannons(tx.fee()), weight); | ||
| let new_tx = TxAdded::new(tx.hash(), weight, fee_rate, current_dt); | ||
| self.txs.add_transaction(new_tx); | ||
| self.txs.expire(expired_dt); |
There was a problem hiding this comment.
self.txs.expire(expired_dt); have a return value, but it's never used.
eval-exec
reviewed
Apr 6, 2023
Comment on lines
+104
to
+117
| fn expire(&mut self, expired_dt: Duration) -> usize { | ||
| let count = self | ||
| .0 | ||
| .iter() | ||
| .rev() | ||
| .skip_while(|tx| tx.added_dt < expired_dt) | ||
| .count(); | ||
| let total = self.0.len(); | ||
| if count > 0 && total >= count { | ||
| self.0.truncate(total - count); | ||
| } | ||
| count | ||
| } | ||
|
|
There was a problem hiding this comment.
How about this:
fn expire(&mut self, expired_dt: Duration) -> usize {
let original_len = self.0.len();
self.0.retain(|tx| tx.added_dt >= expired_dt);
original_len - self.0.len()
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
The algorithm of https://bitcoiner.live/?tab=info implements the fee-rate estimator to achieve the goal in #3673, and there are still some limitations, Weight-Units Flow algorithm is mainly for sampling and analyzing the transactions in tx-pool, so it will be available only after the node has been up for a warm-up period, if the estimator is accessed during the warm-up period it will fallback to the mean of the past historical data (21 blocks)
Check List
Tests
Release note