Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade crates #40

Merged
merged 2 commits into from
Dec 3, 2018
Merged

chore: upgrade crates #40

merged 2 commits into from
Dec 3, 2018

Conversation

doitian
Copy link
Member

@doitian doitian commented Nov 29, 2018 •
edited

See #39

@doitian doitian mentioned this pull request Nov 29, 2018
Closed
4 tasks
@zhangsoledad
Copy link
Member

LGTM, be OK with approving this.
Personally, I'd like to use clap_app macros, but that's me.

@doitian doitian merged commit 4c9b397 into nervosnetwork:develop Dec 3, 2018
@doitian doitian deleted the upgrade-crates branch December 3, 2018 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangsoledad zhangsoledad zhangsoledad approved these changes

@jjyr jjyr Awaiting requested review from jjyr

@TheWaWaR TheWaWaR Awaiting requested review from TheWaWaR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doitian @zhangsoledad