deps(script): Update ckb-vm to v0.24.2 #4064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangsoledad
approved these changes
Jul 11, 2023
eval-exec
approved these changes
Jul 11, 2023
eval-exec
reviewed
Jul 11, 2023
| @@ -22,7 +22,7 @@ ckb-traits = { path = "../traits", version = "= 0.112.0-pre" } | |||
| byteorder = "1.3.1" | |||
| ckb-types = { path = "../util/types", version = "= 0.112.0-pre" } | |||
| ckb-hash = { path = "../util/hash", version = "= 0.112.0-pre" } | |||
| ckb-vm = { version = "=0.24.0", default-features = false } | |||
| ckb-vm = { version = "=0.24.2", default-features = false } | |||
There was a problem hiding this comment.
I believe that the Cargo.lock file should also be modified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
When calling
spawnsyscall recursively, the rust stack would be overflowed in 27th depth.What is changed and how it works?
What's Changed:
We moved
instructions_cachefrom stack to heap. See: nervosnetwork/ckb-vm#357We add a test case at same time, It will create the largest call depth we can create.
Note that there is a minor version v0.24.1 in the middle, for detailed change logs, see:
https://github.com/nervosnetwork/ckb-vm/releases/tag/v0.24.1
https://github.com/nervosnetwork/ckb-vm/releases/tag/v0.24.2
Check List
Tests
Release note