Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RPC CHANGE] : Add block_number to TxStatus for get_transaction RPC #4283

Merged
merged 5 commits into from
Jan 8, 2024
Merged

[RPC CHANGE] : Add block_number to TxStatus for get_transaction RPC #4283

merged 5 commits into from
Jan 8, 2024

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Dec 27, 2023 •
edited

What is changed and how it works?

Related changes

  • Add block_number to TxStatus for get_transaction RPC.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note 

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec changed the title Add block_hash to TxStatus for get_transaction RPC Add block_number to TxStatus for get_transaction RPC Dec 27, 2023
@eval-exec eval-exec changed the title Add block_number to TxStatus for get_transaction RPC **RPC CHANGE** : Add block_number to TxStatus for get_transaction RPC Jan 4, 2024
@eval-exec eval-exec changed the title **RPC CHANGE** : Add block_number to TxStatus for get_transaction RPC *RPC CHANGE* : Add block_number to TxStatus for get_transaction RPC Jan 4, 2024
@eval-exec eval-exec changed the title *RPC CHANGE* : Add block_number to TxStatus for get_transaction RPC [RPC CHANGE] : Add block_number to TxStatus for get_transaction RPC Jan 4, 2024
@eval-exec eval-exec added the b:rpc Break RPC interface label Jan 4, 2024
@eval-exec eval-exec marked this pull request as ready for review January 4, 2024 04:33
@eval-exec eval-exec requested a review from a team as a code owner January 4, 2024 04:33
@quake quake added this pull request to the merge queue Jan 8, 2024
Merged via the queue into nervosnetwork:develop with commit c6929d0 Jan 8, 2024
32 checks passed
@doitian doitian mentioned this pull request Jan 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

@doitian doitian Awaiting requested review from doitian

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad

Assignees
No one assigned
Labels
b:rpc Break RPC interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eval-exec @quake