Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING CHANGE] fix(indexer): The end in script_len_range parameter of IndexerSearchKeyFilter is not inclusive #4285

Merged
merged 1 commit into from
Dec 29, 2023
Merged

[BREAKING CHANGE] fix(indexer): The end in script_len_range parameter of IndexerSearchKeyFilter is not inclusive #4285

merged 1 commit into from
Dec 29, 2023

Conversation

EthanYuan
Copy link
Collaborator

@EthanYuan EthanYuan commented Dec 29, 2023 •
edited

What problem does this PR solve?

Fix the issue：the end in script_len_range parameter of IndexerSearchKeyFilter is not inclusive.

 *   script_len_range: [u64; 2], filter cells by script len range, [inclusive, exclusive]

Check List

Tests

  • No code ci-runs-only: [ quick_checks,linters ]

Release note 

Note: Add a note under the PR title in the release note. 
This is a BREAKING CHANGE for rpc `get_cells`, `get_cells_capacity`.

@EthanYuan EthanYuan requested a review from a team as a code owner December 29, 2023 05:31
@EthanYuan EthanYuan requested review from zhangsoledad and quake and removed request for a team December 29, 2023 05:31
@eval-exec eval-exec added the m:indexer module: ckb-indexer label Dec 29, 2023
@eval-exec
Copy link
Collaborator

eval-exec commented Dec 29, 2023 •
edited

This is a break change for fn get_cells, fn get_transactions and fn get_cells_capacity, should add a note in the Release Note.

@eval-exec eval-exec added the breaking change The feature breaks consensus, database, message schema or RPC interface. label Dec 29, 2023
@quake quake added this pull request to the merge queue Dec 29, 2023
Merged via the queue into nervosnetwork:develop with commit 72abd78 Dec 29, 2023
32 of 33 checks passed
@EthanYuan EthanYuan changed the title fix(indexer): The end in script_len_range parameter of IndexerSearchKeyFilter is not inclusive [BREAKING CHANGE] fix(indexer): The end in script_len_range parameter of IndexerSearchKeyFilter is not inclusive Dec 29, 2023
@doitian doitian mentioned this pull request Jan 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

@eval-exec eval-exec eval-exec approved these changes

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad zhangsoledad is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
breaking change The feature breaks consensus, database, message schema or RPC interface. m:indexer module: ckb-indexer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EthanYuan @eval-exec @quake