Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport 114: Add --include-background to include background migrations in migrate subcommand #4358

Merged

Conversation

chenyukang
Copy link
Collaborator

What problem does this PR solve?

If all the migrations can be run in background, user don't need to manually run ckb migrate --force.

We should make it's transparent when all migrations can run in background.

What is changed and how it works?

Add --include-background to check all migrations include background ones.

What's Changed:

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Release note

None: Exclude this PR from the release note.

@chenyukang chenyukang requested a review from a team as a code owner February 21, 2024 02:42
@doitian doitian merged commit 30328a1 into nervosnetwork:rc/v0.114.x Feb 21, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants