New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eth-contracts): add multisig to TokenLockerV2 and CKBChainV2 #87
Conversation
cosinlink
commented
Dec 8, 2020
•
edited
edited
- add multisig to TokenLockerV2 contract based on TokenLocker
- add new tests to TokenLockerV2
- add multisig to CKBChainV2 contract based on CKBChain
- add new tests to CKBChainV2
- add solidity-coverage to generate coverage reports for eth-contracts
- upload coverage reports of eth-contracts to codecov in ci
ef62a2c
to
f62cbf6
Compare
f06582c
to
8d26ba0
Compare
Codecov Report
@@ Coverage Diff @@
## main #87 +/- ##
==========================================
+ Coverage 8.22% 61.20% +52.97%
==========================================
Files 28 14 -14
Lines 4290 750 -3540
Branches 0 130 +130
==========================================
+ Hits 353 459 +106
+ Misses 3937 291 -3646 Continue to review full report at Codecov.
|
uint public constant SIGNATURE_SIZE = 65; | ||
uint public constant VALIDATORS_SIZE_LIMIT = 20; | ||
string public constant name = "Force Bridge CKBChain"; | ||
// ADD_HEADERS_TYPEHASH = keccak256("AddHeaders(bytes data)"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The signature of the add_header
function is AddHeaders(bytes data, bytes signatures)
, but the hash we used here is AddHeaders(bytes data)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In eip-712, when calc TYPEHASH, the signature of the function should not consider the signatures
or r, s, v
paramters, I think this is also the norm.