ci: skip connecting to key locker if api token is not found

nervosnetwork · Oct 27, 2023 · 854c195 · 854c195 · github-actions · Oct 27, 2023
1 parent 0a47f35
commit 854c195
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/.github/workflows/package.yml b/.github/workflows/package.yml
@@ -71,7 +71,7 @@ jobs:
         shell: bash
 
       - name: Setting up the client tools
-        if: matrix.os == 'windows-2019'
+        if: ${{ matrix.os == 'windows-2019' && env.SM_API_KEY != '' }}
         run: |
           curl -X GET  https://one.digicert.com/signingmanager/api-ui/v1/releases/smtools-windows-x64.msi/download -H "x-api-key:%SM_API_KEY%" -o smtools-windows-x64.msi
           msiexec /i smtools-windows-x64.msi /quiet /qn

diff --git a/.github/workflows/package_for_test.yml b/.github/workflows/package_for_test.yml
@@ -82,15 +82,15 @@ jobs:
         shell: bash
 
       - name: Setting up the client tools
-        if: matrix.os == 'windows-2019'
+        if: ${{ matrix.os == 'windows-2019' && env.SM_API_KEY != '' }}
         run: |
           curl -X GET  https://one.digicert.com/signingmanager/api-ui/v1/releases/smtools-windows-x64.msi/download -H "x-api-key:%SM_API_KEY%" -o smtools-windows-x64.msi
           msiexec /i smtools-windows-x64.msi /quiet /qn
           C:\Windows\System32\certutil.exe -csp "DigiCert Signing Manager KSP" -key -user
         shell: cmd
 
       - name: Certificates Sync
-        if: matrix.os == 'windows-2019'
+        if: ${{ matrix.os == 'windows-2019' && env.SM_API_KEY != '' }}
         run: |
           smctl windows certsync
         shell: cmd

diff --git a/packages/neuron-wallet/scripts/customSign.js b/packages/neuron-wallet/scripts/customSign.js
@@ -1,6 +1,11 @@
 const { execSync } = require('node:child_process')
 
 exports.default = async configuration => {
+  if (!process.env.SM_API_KEY) {
+    console.info(`Skip signing because SM_API_KEY and  not configured`)
+    return
+  }
+
   if (!configuration.path) {
     throw new Error(`Path of application is not found`)
   }