refactor network and add cells component with ipc module #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Keith-CY
commented
Feb 2, 2019
•
Keith-CY
commented
- refactor network component, removed functional methods cause they should be placed in context
- add cells with ipc context #29
- set max line length to 120, our screens are much more wider than before.
Refactor network and add cells
ashchan
approved these changes
Feb 3, 2019
ashchan
reviewed
Feb 3, 2019
| }) | ||
|
|
||
| ipcMain.on(MSG.GET_CELLS_BY_TYPE_HASH, (e: Electron.Event, ...args: string[]) => { | ||
| console.log('here') |
There was a problem hiding this comment.
Unnecessary and annoying logout.
| }, | ||
| } | ||
|
|
||
| const chainCtx = createContext(chain) |
There was a problem hiding this comment.
Let use full word for context in var name.
From React's official document, it's better to name this var as: ChainContext.
xiaoluSF
pushed a commit
to xiaoluSF/neuron
that referenced
this pull request
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.