Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Sometimes RPC timeout but ckb is living #2574

Merged
merged 1 commit into from Jan 20, 2023
Merged

fix: Sometimes RPC timeout but ckb is living #2574

merged 1 commit into from Jan 20, 2023

Conversation

yanguoyu
Copy link
Collaborator

  1. Try to check ckb is alive every 30s.
  2. When startCkb try to check the ckb is null.

@yanguoyu
fix: Sometimes RPC timeout but ckb is living
5f944df 
1. Try to check ckb is alive every 30s.
2. When startCkb try to check the ckb is null.
@yanguoyu yanguoyu mentioned this pull request Jan 18, 2023
Closed
Cedar67
Cedar67 approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@Cedar67 Cedar67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. No reproduction in five times.

@Keith-CY
Copy link
Collaborator

I didn't find the reason for point 1 Try to check ckb is alive every 30s. in the related issue, please add a brief explanation.

@yanguoyu
Copy link
Collaborator Author

I didn't find the reason for point 1 Try to check ckb is alive every 30s. in the related issue, please add a brief explanation.

I think 10s is too faster, It's unnecessary.

@Keith-CY Keith-CY merged commit 80b5802 into nervosnetwork:develop Jan 20, 2023
@Keith-CY Keith-CY mentioned this pull request Feb 1, 2023
Open
@yanguoyu yanguoyu deleted the fix-ckb-monitor branch February 22, 2023 06:07
@yanguoyu yanguoyu mentioned this pull request Feb 22, 2023
Closed
This was referenced Mar 1, 2023
Closed
Closed
This was referenced May 27, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keith-CY Keith-CY Keith-CY approved these changes

@Cedar67 Cedar67 Cedar67 approved these changes

@JeffreyMa597 JeffreyMa597 Awaiting requested review from JeffreyMa597

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yanguoyu @Keith-CY @Cedar67