Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve the interaction design of the DatetimePicker component #2674

Merged
merged 2 commits into from May 23, 2023

Conversation

WhiteMinds
Copy link
Contributor

@WhiteMinds WhiteMinds commented May 19, 2023

feat: improve the interaction design of the DatetimePicker component

Ref: Magickbase/neuron-public-issues#151

iShot_2023-05-19_10.44.07.mp4

@Keith-CY
Copy link
Collaborator

Please review the interaction @Danie0918, @Sven-TBD

@Danie0918
Copy link
Collaborator

Note that when no date is selected, the save button is unavailable instead of hidden. In this case, it is recommended to unify the copywriting as "locked to".

@WhiteMinds
Copy link
Contributor Author

Note that when no date is selected, the save button is unavailable instead of hidden. In this case, it is recommended to unify the copywriting as "locked to".

Resolved

@WhiteMinds
Copy link
Contributor Author

This is the result after making changes based on the comments in the PR:

iShot_2023-05-22_11.22.02.mp4

Additionally, for the translation key, I chose to use release-on, but it may not align with the initial locked to mentioned in the product:

image

@Danie0918 Should I specify a new key, or should we continue using "release-on"?

@Danie0918
Copy link
Collaborator

This is the result after making changes based on the comments in the PR:

iShot_2023-05-22_11.22.02.mp4
Additionally, for the translation key, I chose to use release-on, but it may not align with the initial locked to mentioned in the product:

image @Danie0918 Should I specify a new key, or should we continue using "release-on"?

Verified

@Keith-CY
Copy link
Collaborator

Please have a review @FrederLu @silySuper @littleLip520

@FrederLu
Copy link
Collaborator

@WhiteMinds
Testers need to verify the PR through the test package. This PR is initiated from your own Repo, so the packaging process cannot be triggered.
It needs to be initiated from the Repo under nervosnetwork to trigger the packaging process because a certificate is required.
Please re-operate the pr submission process.
Status quo
image


Desired state
image
image
image

@WhiteMinds
Copy link
Contributor Author

@Keith-CY I believe it's quite common for the source branch of a PR to not be on the main repository. Considering that, we should modify the workflow. Here are a few options:

  1. use fail-fast: false

  2. Check if it is the main repository before executing Package for MacOS, and automatically skip if it is not

  3. Check for the presence of necessary secrets before executing Package for MacOS, and output a warning message if they are missing

  4. Automatically switch to non-signing mode and output a warning when the required signing secrets are missing

@FrederLu I have just pushed the branch to the main repository. You can now access the packaging result through this link: a9eea2e#commitcomment-114552831

@Keith-CY
Copy link
Collaborator

Keith-CY commented May 23, 2023

@Keith-CY I believe it's quite common for the source branch of a PR to not be on the main repository. Considering that, we should modify the workflow. Here are a few options:

  1. use fail-fast: false
  2. Check if it is the main repository before executing Package for MacOS, and automatically skip if it is not
  3. Check for the presence of necessary secrets before executing Package for MacOS, and output a warning message if they are missing
  4. Automatically switch to non-signing mode and output a warning when the required signing secrets are missing

@FrederLu I have just pushed the branch to the main repository. You can now access the packaging result through this link: a9eea2e#commitcomment-114552831

I'll open an issue to improve the workflow of packaging for test


Will be tracked at Magickbase/neuron-public-issues#154

@FrederLu
Copy link
Collaborator

@Keith-CY I believe it's quite common for the source branch of a PR to not be on the main repository. Considering that, we should modify the workflow. Here are a few options:

  1. use fail-fast: false
  2. Check if it is the main repository before executing Package for MacOS, and automatically skip if it is not
  3. Check for the presence of necessary secrets before executing Package for MacOS, and output a warning message if they are missing
  4. Automatically switch to non-signing mode and output a warning when the required signing secrets are missing

@FrederLu I have just pushed the branch to the main repository. You can now access the packaging result through this link: a9eea2e#commitcomment-114552831

Thanks, the test package has been downloaded through the portal.

@Keith-CY Keith-CY added this pull request to the merge queue May 23, 2023
Merged via the queue into nervosnetwork:develop with commit 99dbd96 May 23, 2023
12 checks passed
@Keith-CY Keith-CY mentioned this pull request May 27, 2023
@WhiteMinds WhiteMinds deleted the feat/151_ImproveCalendarUX branch May 31, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants