fix: Avoid generate deposit DAO when the dialog is not visible. #2760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanguoyu
requested review from
Keith-CY,
homura,
WhiteMinds,
devchenyan,
alexsupa597,
FrederLu,
silySuper and
littleLip520
|
/package |
|
Because the latest |
WhiteMinds
approved these changes
Jul 5, 2023
Keith-CY
approved these changes
Jul 5, 2023
|
This is a hotfix on the released one, please prioritize this one @FrederLu @silySuper @littleLip520 |
alexsupa597
approved these changes
Jul 5, 2023
littleLip520
approved these changes
Jul 7, 2023
This was referenced Jul 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened:
When on the DAO page, the deposit DAO transaction will generate when the suggestion fee changes. So when the users withdraw DAO, the withdraw DAO transaction may change to a deposit transaction.
Resolution
When the deposit dialog is not open, the deposit transaction will not generate.