New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support spore nft #2810
feat: support spore nft #2810
Conversation
/package |
I found there were some circular dependencies in Neuron, maybe we should find a way to avoid it Details
|
# Conflicts: # yarn.lock
/package |
# Conflicts: # packages/neuron-wallet/package.json # yarn.lock
I'm a bit confused about this point. Does it say that we should prevent users from transferring spores to the same address?
I think is a feature instead of a bug because Nueron only treats the cells without data as spendable cells, so I suggest we keep the same here. @Keith-CY @yanguoyu What are your ideas about this point? neuron/packages/neuron-wallet/src/services/cells.ts Lines 85 to 86 in f3cc18a
|
For No.1 send NFT to itself is a useful operation? @Danie0918 if it is not ,it is better to have a tip for users. |
I'm sure that balance does not include cells' capacity that the cells include data. Neurons will not cost the cells that have data when transferring CKB. |
This is something that can be initiated normally without prompting, similar to sending CKB. |
Screen.Recording.2023-11-06.at.16.44.16.movTransferring spores via the light client is supported, please have a check, @silySuper |
/package |
For No.1,send CKB will have tip when send and receive is same.So send NFT need tip @Danie0918 ? |
If you can receive the NFT normally you don't need to be prompted, it's a limitation of the APC account here, isn't it? |
No.3 Verified. |
No.1 and No.2 not need to change. |
2023-11-09.17.13.06.mov |
Light client sync failed. @homura This is the debug log. |
Hi @silySuper, did you run more than one light client at the same during the test? If yes, then the light client may not be working correctly.
|
Today from activity monitor,there is no ckb process and can sync. |
Send feature has verified. |
So you mean that the sync of the light client is working well, right?
Does it mean that the PR is completely tested? |
Yes |
Resolves: Magickbase/neuron-public-issues#252
Limitation with The Light Client
[ID][Cluster Name] Spore
[ID][Cluster ID] Spore
When working with the light client in this PR, the
[Cluster Name]
part is displayed as aCluster ID
. This is because it is difficult to resolve the cluster cell from a spore cell, which is not owned by the wallet. To search the cluster cell that derives the spore cell, we need to:cluster_id
from a spore cell's data if the spore is born from a clustercode_hash: cluster_code_hash, data: data1, args: cluster_id
and search in the CKB indexerThis limitation appears because Neuron only subscribes to lock scripts owned by a wallet, while the cluster cell may not belong to it.
Although we can subscribe to the cluster cells not owned by the wallet, it will make the light client heavier. If we subscribe to more scripts to make the features the same as the full node, the light client will lose its lightness. Therefore, I believe that the trade-off here may be acceptable.
Notes