Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change default network name to Internal Node #2813

Merged
merged 2 commits into from Aug 31, 2023

Conversation

yanguoyu
Copy link
Collaborator

  1. Download and install Neuron for the first time. We can mock this to delete the network.json file at /Users/{username}/Library/Application Support/Neuron/networks/index.json

before:

image

after migrate:

image
  1. Has added a new network but not edit the default network

before:

image

after migrate:

image
  1. Has added a new network and edited the default network

before:

image

after migrate:

image

@silySuper
Copy link
Collaborator

silySuper commented Aug 29, 2023

/package.
Packaging for test is done in 6010412901. @silySuper

@silySuper
Copy link
Collaborator

I need to verify that does the internal node whether support edit or not now?

@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Aug 30, 2023

I need to verify that does the internal node whether support edit or not now?

of course

@Keith-CY Keith-CY added this pull request to the merge queue Aug 31, 2023
Merged via the queue into nervosnetwork:develop with commit 101b7e1 Aug 31, 2023
10 checks passed
@yanguoyu yanguoyu deleted the feat-network-default branch August 31, 2023 09:45
@Keith-CY Keith-CY mentioned this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants