Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Setting font for linux #2873

Merged
merged 1 commit into from Oct 17, 2023
Merged

fix: Setting font for linux #2873

merged 1 commit into from Oct 17, 2023

Conversation

yanguoyu
Copy link
Collaborator

@yanguoyu yanguoyu commented Oct 12, 2023 •
edited

  1. mac

    • zh
      image
    • en image

  2. Windows

    • zh
      image

    • en
      image

  3. Linux

    • zh
      image
    • en
      image

@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Oct 12, 2023 •
edited by github-actions bot

/package for test font
Packaging for test is done in 6502819118. @yanguoyu

@yanguoyu yanguoyu marked this pull request as ready for review October 13, 2023 03:37
@yanguoyu
Copy link
Collaborator Author

@Kirl70 please help me check whether these fonts display is normal.

@yanguoyu yanguoyu mentioned this pull request Oct 13, 2023
Closed
@Kirl70
Copy link

Kirl70 commented Oct 13, 2023

@Kirl70 please help me check whether these fonts display is normal.

I think the font display meets expectations.

@Keith-CY
Copy link
Collaborator

Verified on Linux

@Keith-CY Keith-CY merged commit 0c48a06 into nervosnetwork:develop Oct 17, 2023
10 checks passed
@yanguoyu yanguoyu deleted the fix-linux-font branch October 17, 2023 02:59
@Keith-CY Keith-CY mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keith-CY Keith-CY Keith-CY approved these changes

@devchenyan devchenyan devchenyan approved these changes

@homura homura Awaiting requested review from homura

@WhiteMinds WhiteMinds Awaiting requested review from WhiteMinds

@silySuper silySuper Awaiting requested review from silySuper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yanguoyu @Kirl70 @Keith-CY @devchenyan