fix: Fix light client sync miss some tx. #2992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanguoyu
force-pushed
the
fix-light-sync
branch
5 times, most recently
from
2116e2f
to
e04879a
Compare
|
/package |
This package always throws |
|
/package |
yanguoyu
requested review from
Keith-CY,
homura,
WhiteMinds,
devchenyan,
FrederLu and
silySuper
Keith-CY
reviewed
Dec 28, 2023
...ges/neuron-wallet/src/database/chain/migrations/1690361215400-ResetSyncProgressPrimaryKey.ts
Show resolved
Hide resolved
packages/neuron-wallet/src/block-sync-renderer/sync/light-synchronizer.ts
Outdated
Show resolved
Hide resolved
1. Use `partial` and `delete` for set_scripts 2. Sync the next block number after all addresses are synced to the block number 3. Rename `blockStartNumber` to `localSavedBlockNumber`, rename `blockEndNumber` to `syncedBlockNumber`
yanguoyu
force-pushed
the
fix-light-sync
branch
from
7c9e564
to
85fcfcd
Compare
Keith-CY
approved these changes
Dec 28, 2023
|
/package |
|
Please have a review @homura @WhiteMinds @devchenyan @zhangyouxin |
homura
reviewed
Dec 29, 2023
packages/neuron-wallet/src/block-sync-renderer/sync/light-synchronizer.ts
Show resolved
Hide resolved
homura
reviewed
Dec 29, 2023
...ges/neuron-wallet/src/database/chain/migrations/1690361215400-ResetSyncProgressPrimaryKey.ts
Show resolved
Hide resolved
homura
approved these changes
Dec 29, 2023
|
/package |
homura
approved these changes
Jan 4, 2024
|
Neuron in windows can not sync for about two days,sync process can not change or alaways show '正在连接节点'. |
silySuper
approved these changes
Jan 10, 2024
yanguoyu
added a commit
to yanguoyu/neuron
that referenced
this pull request
Mar 14, 2024
* refactor: Rename connector to synchronizer * fix: fix light sync logic 1. Use `partial` and `delete` for set_scripts 2. Sync the next block number after all addresses are synced to the block number 3. Rename `blockStartNumber` to `localSavedBlockNumber`, rename `blockEndNumber` to `syncedBlockNumber`
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to Magickbase/neuron-public-issues#329 (comment).
Additionally, I rename
ConnectortoSynchronizerrefer to https://github.com/nervosnetwork/neuron/pull/2965/files#r1412661113. For more clarity, RenameblockStartNumbertolocalSavedBlockNumber, renameblockEndNumbertosyncedBlockNumberin thesync_progresstable.