Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Non-Native token transfer in history add more details about CKB #3040

Merged
merged 1 commit into from Mar 6, 2024

Conversation

yanguoyu
Copy link
Collaborator

Refer to Magickbase/neuron-public-issues#335

  1. History detail
feat-335.mov
  1. Cell manage
cell-manager.mov

@Danie0918
Copy link
Collaborator

@homura @WhiteMinds @devchenyan Please have a review.

packages/neuron-ui/src/locales/fr.json Outdated Show resolved Hide resolved
@silySuper
Copy link
Collaborator

silySuper commented Feb 27, 2024

/package
Packaging for test is done in 8058321127. @silySuper

@silySuper
Copy link
Collaborator

1.As I know that the combination of a tx_hash and an index is called an "out point".Why not show index?
截屏2024-02-27 16 24 40

2.In transaction history page,cell info cannot see clearly in dark mode.
截屏2024-02-27 16 08 03

3.In history detail page,type field is sending,imo it should be same to type field in history page.

2024-02-27.16.31.45.mov

@yanguoyu
Copy link
Collaborator Author

1.As I know that the combination of a tx_hash and an index is called an "out point".Why not show index?

@Danie0918 Could we just append the index at the end of the transaction hash or show the index in another way?

@Danie0918
Copy link
Collaborator

1.As I know that the combination of a tx_hash and an index is called an "out point".Why not show index?

@Danie0918 Could we just append the index at the end of the transaction hash or show the index in another way?

Here, it is used to help the user confirm the source of the cell, the index is not important and can be ignored.

@yanguoyu
Copy link
Collaborator Author

1.As I know that the combination of a tx_hash and an index is called an "out point".Why not show index?

@Danie0918 Could we just append the index at the end of the transaction hash or show the index in another way?

Here, it is used to help the user confirm the source of the cell, the index is not important and can be ignored.

Maybe we can rename Outpoint to TxHash? OutPoint is a bit confusing.

@Danie0918
Copy link
Collaborator

1.As I know that the combination of a tx_hash and an index is called an "out point".Why not show index?

@Danie0918 Could we just append the index at the end of the transaction hash or show the index in another way?

Here, it is used to help the user confirm the source of the cell, the index is not important and can be ignored.

Maybe we can rename Outpoint to TxHash? OutPoint is a bit confusing.

This part does get confusing, let's hide this part for now and decide when the CKB Explorer is released.

@yanguoyu
Copy link
Collaborator Author

1.As I know that the combination of a tx_hash and an index is called an "out point".Why not show index? 截屏2024-02-27 16 24 40

2.In transaction history page,cell info cannot see clearly in dark mode. 截屏2024-02-27 16 08 03

3.In history detail page,type field is sending,imo it should be same to type field in history page.

2024-02-27.16.31.45.mov

Fixed

@silySuper
Copy link
Collaborator

4.In history page , click view on explorer,jump to https://pudge.explorer.nervos.org/transaction/0x5ad59f79cef0c9c38d656ac7eb5368f9d9c546992c9222330cea8d8fe31c87f1 and fee UI shows abnormal.
截屏2024-02-29 09 26 05

5.When send sudt,it shows like this in history page,balance equals to transaction fee in history detail.
截屏2024-02-29 09 41 33

截屏2024-02-29 09 44 16

3.By the way,light client can not sync again,stay at 99.85%.
main.log

@yanguoyu
Copy link
Collaborator Author

4.In history page , click view on explorer,jump to https://pudge.explorer.nervos.org/transaction/0x5ad59f79cef0c9c38d656ac7eb5368f9d9c546992c9222330cea8d8fe31c87f1 and fee UI shows abnormal. 截屏2024-02-29 09 26 05

I believe it will be better to create an issue for the explorer.

3.By the way,light client can not sync again,stay at 99.85%. main.log

From the last log, it shows sync to 12414813, I guess you should wait for a while, if it still stuck, it's better to upload the light-client run log.

@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Mar 1, 2024

5.When send sudt,it shows like this in history page,balance equals to transaction fee in history detail.

Fixed

@silySuper
Copy link
Collaborator

silySuper commented Mar 5, 2024

/package

Packaging for test is done in 8166028367. @silySuper

@Keith-CY
Copy link
Collaborator

Keith-CY commented Mar 6, 2024

/package
Packaging for test is done in 8166078017. @Keith-CY

@silySuper
Copy link
Collaborator

The test package for mac-arm64 above can not open normally,shows:
截屏2024-03-06 10 57 02

@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Mar 6, 2024

The test package for mac-arm64 above can not open normally,shows: 截屏2024-03-06 10 57 02

Magickbase/neuron-public-issues#154 (comment)
Magickbase/neuron-public-issues#154 (comment)
Here is the solution for opening an unsigned App on Mac os

@silySuper
Copy link
Collaborator

silySuper commented Mar 6, 2024

1.verified
2.verified
3.verified
4.has created a new issue
5.verified

@yanguoyu yanguoyu added this pull request to the merge queue Mar 6, 2024
Merged via the queue into nervosnetwork:develop with commit 9d5db26 Mar 6, 2024
10 checks passed
@yanguoyu yanguoyu deleted the feat-335 branch March 6, 2024 09:20
@Keith-CY Keith-CY mentioned this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants