Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: For windows os the user need to start the Neuron manually after installed. #3196

Merged
merged 1 commit into from
Jun 26, 2024
Merged

fix: For windows os the user need to start the Neuron manually after installed. #3196

merged 1 commit into from
Jun 26, 2024

Conversation

yanguoyu
Copy link
Collaborator

@yanguoyu yanguoyu commented Jun 21, 2024 •
edited
Loading

@yanguoyu yanguoyu changed the title fix: Force run after install new version fix: For windows os the user need to start the Neuron manually after installed. Jun 21, 2024
@yanguoyu yanguoyu marked this pull request as ready for review June 21, 2024 09:26
@yanguoyu yanguoyu mentioned this pull request Jun 21, 2024
Open
@Danie0918
Copy link
Collaborator

@homura @twhy Please have a review.

@silySuper
Copy link
Collaborator

silySuper commented Jun 25, 2024 •
edited by github-actions bot
Loading

/package

Packaging for test is done in 9658210868. @silySuper

@silySuper
Copy link
Collaborator

silySuper commented Jun 25, 2024 •
edited
Loading

截屏2024-06-25 16 41 32 截屏2024-06-25 16 50 48

@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Jun 25, 2024 •
edited
Loading

截屏2024-06-25 16 41 32 截屏2024-06-25 16 50 48

Magickbase/neuron-public-issues#397 (comment) and notice the PR title

@silySuper
Copy link
Collaborator

silySuper commented Jun 26, 2024 •
edited
Loading 

    confirmText={t(`updates.${isWin ? 'quit-and-install-restart' : 'quit-and-install'}`)}

if iswin true shows quit-and-install-restart，if not shows quit-and-install
so when iswin,expect to show relaunch or not ?

@yanguoyu yanguoyu added this pull request to the merge queue Jun 26, 2024
Merged via the queue into nervosnetwork:develop with commit 4493d79 Jun 26, 2024
10 checks passed
@yanguoyu yanguoyu deleted the fix-auto-open branch June 26, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keith-CY Keith-CY Keith-CY approved these changes

@twhy twhy twhy approved these changes

@devchenyan devchenyan devchenyan approved these changes

@silySuper silySuper silySuper approved these changes

@homura homura Awaiting requested review from homura

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yanguoyu @Danie0918 @silySuper @Keith-CY @twhy @devchenyan