Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default text color is now a dark grey #1213

Closed
MineRobber9000 opened this issue Oct 20, 2020 · 5 comments
Closed

Default text color is now a dark grey #1213

MineRobber9000 opened this issue Oct 20, 2020 · 5 comments
Assignees

Comments

@MineRobber9000
Copy link
Contributor

MineRobber9000 commented Oct 20, 2020

The default text color when you use a print statement is 15, as per the wiki:

print text [x=0 y=0] [color=15] [fixed=false] [scale=1] [smallfont=false] -> width

When we still used DB16, this was white, which paired with the black, gave great contrast. Now, color 15 is a dark grey that does not contrast well with a black background.

Is this a conscious choice? Maybe the default color could become 12, which is white in the new palette?

Quickly editing to note that I understand why the palette is in the order it is, just asking if you intended for the default text color to become dark grey.

@nesbox nesbox self-assigned this Oct 21, 2020
@nesbox nesbox added this to To do in dev version 0.90 via automation Oct 21, 2020
@nesbox nesbox moved this from To do to In progress in dev version 0.90 Oct 21, 2020
@nesbox
Copy link
Owner

nesbox commented Oct 21, 2020

Fixed here 7d9ca33.
Thank you.

@nesbox nesbox closed this as completed Oct 21, 2020
dev version 0.90 automation moved this from In progress to Done Oct 21, 2020
@StinkerB06
Copy link

Wouldn't this break carts using the previous DB16 palette or any other palette besides Sweetie-16?

@nesbox
Copy link
Owner

nesbox commented Oct 21, 2020

Yes, it would break, I think it's not significant, we have a new default palette with new color by default.

@MineRobber9000
Copy link
Contributor Author

But what about older carts released for earlier versions? Won't this break them? Maybe it should have just been left alone...

@nesbox
Copy link
Owner

nesbox commented Oct 23, 2020

Maybe, time will tell us. We will revert to the default color in case of serious problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

3 participants