Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a chunk to load default palette/waveforms #1308

Closed
nesbox opened this issue Jan 25, 2021 · 4 comments
Closed

Add a chunk to load default palette/waveforms #1308

nesbox opened this issue Jan 25, 2021 · 4 comments
Assignees
@nesbox
Projects
dev version 0.90

Comments

@nesbox
Copy link
Owner

nesbox commented Jan 25, 2021

No description provided.

@nesbox nesbox self-assigned this Jan 25, 2021
@nesbox nesbox added this to To do in dev version 0.90 via automation Jan 25, 2021
@nesbox nesbox moved this from To do to In progress in dev version 0.90 Jan 25, 2021
nesbox added a commit that referenced this issue Jan 25, 2021
@nesbox
#1308: added new chunk CHUNK_DEFAULT which loads default palette/wave…
8ec5a27 
…forms
@nesbox nesbox changed the title Add a chunk to load default palette/waveforms by default Add a chunk to load default palette/waveforms Jan 25, 2021
@nesbox
Copy link
Owner Author

nesbox commented Jan 25, 2021

Added here 8ec5a27

@nesbox nesbox closed this as completed Jan 25, 2021
dev version 0.90 automation moved this from In progress to Done Jan 25, 2021
@joshgoebel
Copy link
Collaborator

loadDefauts is a typo, yes?

And doesn't this change the behavior of all existing cartridges defaulting them to the older DB16 palette because they would be missing the new "load defaults" chunk?

nesbox added a commit that referenced this issue Jan 26, 2021
@nesbox
#1308: detect CHUNK_DEFAULT on cart saving
29df578
@nesbox
Copy link
Owner Author

nesbox commented Jan 26, 2021

Yes, it's a typo, thanks.
No, this doesn't change the behavior, Sweetie16 palette will be loaded if CHUNK_DEFAULT exists, in other cases palette from the cart will be loaded, or DB16 if there is no palette chunk in the cart.

@joshgoebel
Copy link
Collaborator

Ok I got it. :) This second commit is a lot clearer I think. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nesbox nesbox

Labels
None yet
Projects
No open projects
dev version 0.90
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshgoebel @nesbox