Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Please add THEME.CODE.FG to alter foreground text in code editor #1312

Closed
joshgoebel opened this issue Jan 26, 2021 · 4 comments
Closed
Assignees

Comments

@joshgoebel
Copy link
Collaborator

joshgoebel commented Jan 26, 2021

Screen Shot 2021-01-26 at 6 30 32 PM

I would prefer my text not also be purple here.

The UI colors are fixed (am I wrong?) so that means if one wants to customize their top and bottom borders that requires editing palette entry 12 - which unfortunately also has the side effect of changing all the text (and console) to whatever new color is chosen.

There should be a was to specify a custom "default" foreground/text color with themes.

@nesbox nesbox added this to To do in dev version 0.90 via automation Jan 27, 2021
@joshgoebel
Copy link
Collaborator Author

joshgoebel commented Jan 28, 2021

So I tracked this as far as drawCode and line 240:

drawChar(code->tic, symbol, x, y, colors[syntaxPointer->syntax], code->altFont);

But it seems it should always be using a color from the theme (based on the syntaxPointer->syntax array index)... but my theme doesn't have 13 (white) in it other than sign and cursor... so I'm not sure where in the stack that default (no highlight) color 13 is coming in...

@joshgoebel
Copy link
Collaborator Author

joshgoebel commented Jan 29, 2021

LOL, so everything is a variable by default... um ok. :-) So one can edit the foreground color with VAR.

    for(s32 i = 0; i < TIC_CODE_SIZE; i++)
        code->state[i].syntax = SyntaxTypeVar;

@nesbox nesbox moved this from To do to In progress in dev version 0.90 Apr 8, 2021
@nesbox
Copy link
Owner

nesbox commented Apr 13, 2021

Added THEME.CODE.FG to the config + some refactoring 09e2370

@nesbox nesbox closed this as completed Apr 13, 2021
dev version 0.90 automation moved this from In progress to Done Apr 13, 2021
@nesbox nesbox self-assigned this Apr 13, 2021
@joshgoebel
Copy link
Collaborator Author

Much saner naming. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants