Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bank parameter for music export #2202

Merged
merged 1 commit into from May 22, 2023
Merged

Fix bank parameter for music export #2202

merged 1 commit into from May 22, 2023

Conversation

borbware
Copy link
Sponsor Contributor

This commit fixes the bank parameter for exporting music (see issue #2190).

There is still some ambiguity present, because the exported music depends on the sfx bank as well.

If bank chaining is on, the exported music uses the same sfx bank as the music bank.
If bank chaining is off, the exported music uses the sfx from the currently active sfx bank.

This could be fixed by introducing a chained=true/false parameter for the export.

@borbware
Copy link
Sponsor Contributor Author

Note: I didn't manage to call the static switchBank function, so I implemented some of its functionality inside studioExportMusic.

@nesbox nesbox added this to To do in dev version 1.1 via automation May 22, 2023
@nesbox nesbox linked an issue May 22, 2023 that may be closed by this pull request
@nesbox nesbox merged commit 687fb34 into nesbox:main May 22, 2023
31 checks passed
dev version 1.1 automation moved this from To do to Done May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Bank parameter does not work for exporting music
2 participants