-
-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump Janet version to v1.34 #2539
Conversation
took a minute to find the actual windows failure, heres the line https://github.com/nesbox/TIC-80/actions/runs/8853673596/job/24315055075?pr=2539#step:4:3165
|
from what I can tell that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have problem with InterlockedIncrement
on windows because ${THIRDPARTY_DIR}/janet/build/c/janet.c doesn't include windows.h
I approve it and later will create a workaround to fix this
I'll chat with the Janet community! I don't think we have any sort of automated builds for Windows, especially not windows XP. So there could be a change I just didn't see. Hopefully I'll be able to reproduce the Janet windows XP build errors independent of tic80 |
there are build & test ci/cd jobs for windows, just not windows XP https://github.com/janet-lang/janet/actions/runs/8777715785/job/24083063634?pr=1438 |
I'm thinking of reopening PR and trying to fix the build separately |
also removed the
strict: true
from the demo cart, which was incorrectly copy/pasted from the fennel demo cart.