Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump Janet version to v1.34 #2539

Merged
merged 3 commits into from
Apr 27, 2024
Merged

bump Janet version to v1.34 #2539

merged 3 commits into from
Apr 27, 2024

Conversation

AlecTroemel
Copy link
Sponsor Contributor

@AlecTroemel AlecTroemel commented Apr 26, 2024

also removed the strict: true from the demo cart, which was incorrectly copy/pasted from the fennel demo cart.

@AlecTroemel
Copy link
Sponsor Contributor Author

took a minute to find the actual windows failure, heres the line https://github.com/nesbox/TIC-80/actions/runs/8853673596/job/24315055075?pr=2539#step:4:3165

janet.lib(janet.c.obj) : error LNK2019: unresolved external symbol InterlockedIncrement referenced in function janet_atomic_inc [D:\a\TIC-80\TIC-80\build\cart2prj.vcxproj]

@AlecTroemel
Copy link
Sponsor Contributor Author

from what I can tell that InterlockedIncrement function call has been around forever. My gut says this is something off with the build configuration

Copy link
Owner

@nesbox nesbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have problem with InterlockedIncrement on windows because ${THIRDPARTY_DIR}/janet/build/c/janet.c doesn't include windows.h
I approve it and later will create a workaround to fix this

@nesbox nesbox added this to In progress in dev version 1.2 via automation Apr 27, 2024
@nesbox nesbox merged commit 9f5ce52 into nesbox:main Apr 27, 2024
15 of 21 checks passed
dev version 1.2 automation moved this from In progress to Done Apr 27, 2024
nesbox added a commit that referenced this pull request Apr 27, 2024
@nesbox
Copy link
Owner

nesbox commented Apr 27, 2024

Unfortunately, I wasn't able to fix the Winxp build, a lot of errors.
image
So I reverted the PR for now to the old Janet version, sorry.

@AlecTroemel
Copy link
Sponsor Contributor Author

AlecTroemel commented Apr 27, 2024

I'll chat with the Janet community! I don't think we have any sort of automated builds for Windows, especially not windows XP. So there could be a change I just didn't see.

Hopefully I'll be able to reproduce the Janet windows XP build errors independent of tic80

@AlecTroemel
Copy link
Sponsor Contributor Author

there are build & test ci/cd jobs for windows, just not windows XP https://github.com/janet-lang/janet/actions/runs/8777715785/job/24083063634?pr=1438

@nesbox
Copy link
Owner

nesbox commented Apr 28, 2024

I'm thinking of reopening PR and trying to fix the build separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants