cMask::Init possible copy/paste issue

[tico-tico]

While refactoring i found this stuff:

    outpost_map[WC] = bb_rel_rank[WC][RANK_4] | bb_rel_rank[WC][RANK_5] | bb_rel_rank[WC][RANK_6];
    outpost_map[BC] = bb_rel_rank[BC][RANK_4] | bb_rel_rank[BC][RANK_5] | bb_rel_rank[BC][RANK_6];
    outpost_map[WC] = outpost_map[WC] & bbNotA;
    outpost_map[WC] = outpost_map[WC] & bbNotH;
    outpost_map[BC] = outpost_map[WC] & bbNotA;
    outpost_map[BC] = outpost_map[WC] & bbNotH;

take a look at the last two lines, don't you think that this should be better:

    outpost_map[BC] = outpost_map[BC] & bbNotA;
    outpost_map[BC] = outpost_map[BC] & bbNotH;

If you think that it's true, please just reply here, don't change the code, 'coz as i said i'm in the process of refactoring of this.

[nescitus]

Yes, You are right about this bug. Thank You for spotting it! pk

…

On 6 September 2017 at 22:14, tico-tico ***@***.***> wrote: While refactoring i found this stuff: outpost_map[WC] = bb_rel_rank[WC][RANK_4] | bb_rel_rank[WC][RANK_5] | bb_rel_rank[WC][RANK_6]; outpost_map[BC] = bb_rel_rank[BC][RANK_4] | bb_rel_rank[BC][RANK_5] | bb_rel_rank[BC][RANK_6]; outpost_map[WC] = outpost_map[WC] & bbNotA; outpost_map[WC] = outpost_map[WC] & bbNotH; outpost_map[BC] = outpost_map[WC] & bbNotA; outpost_map[BC] = outpost_map[WC] & bbNotH; take a look at the last two lines, don't you think that this should be better: outpost_map[BC] = outpost_map[BC] & bbNotA; outpost_map[BC] = outpost_map[BC] & bbNotH; If you think that it's true, please just reply here, don't change the code, 'coz as i said i'm in the process of refactoring of this. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#55>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABEHaOmhFotCZza_6VDs1ZdGsr9b_vQlks5sfv0YgaJpZM4PO6PP> .