-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added repository status to the CLI status display. #86
Conversation
This is displayed in the watched repository table in the CLI status. In the process I have also extracted the code for checking if the working directory is dirty into its own method, and test it.
Looks like the travis CI build failed? |
Yeah, there seems to be an issue with the character that I am using for marking needs_sync in the CLI, but only in ruby1.9. It was generating a syntax error, but I changed the character and added the encoding string, and now Aruba seems to not properly understand the character. |
This is a good practises in general, but hopefully it will also make the UTF-8 characters that I wish to use in the CLI work consistently across Ruby1.9 and Ruby2.0.
This is also displayed in the watched repository table in the CLI status. Shows if the repository needs to be pushed or merged. Not using any fancy UTF-8 symbols for the status as they will not always work in ruby1.9. Maybe try this later when 1.9 support is dropped.
I think that this makes the logic of the when to push or sync a little easier to read.
Which hopefully will avoid failures due to slow execution on Travis.
@nesquena ready for a review and merge |
Forgot to update the CHANGELOG, but that should be fixed now. |
Awesome! Looks good, thanks for updating the changelog too. |
Added repository status to the CLI status display.
This will show if the watched repositories are fully committed or need to be synced.
It will be particularly useful to see if a fetch_only repository has commits which can be merged.