Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rabl 0.9.1 breaks 1.8.7 compatibility #508

Closed
skottler opened this issue Nov 18, 2013 · 4 comments
Closed

rabl 0.9.1 breaks 1.8.7 compatibility #508

skottler opened this issue Nov 18, 2013 · 4 comments

Comments

@skottler
Copy link

0.9.0 is fine, but 0.9.1 breaks 1.8.7 compatibility:

/usr/local/rvm/gems/ruby-1.8.7-p371@test_develop_pull_request-0/gems/rabl-0.9.1/lib/rabl/builder.rb:150: syntax error, unexpected '!', expecting tSTRING_CONTENT or tSTRING_DBEG or tSTRING_DVAR or tSTRING_END
...ptions[:unless], @_object, &:!)
                              ^
/usr/local/rvm/gems/ruby-1.8.7-p371@test_develop_pull_request-0/gems/rabl-0.9.1/lib/rabl/builder.rb:188: syntax error, unexpected $end, expecting kEND

In .travis.yml you have a this:

matrix:
  allow_failures:
    - rvm: 1.8.7

Given the fact that lots of people rely on rabl and I'm sure folks are still on 1.8.7, it probably makes sense to actually fail the build when 1.8.7 doesn't work anymore.

@nesquena
Copy link
Owner

Thanks for bringing up the issue. Will fix this as soon as I can.

@evgeni
Copy link

evgeni commented Nov 19, 2013

/ sub

@nesquena
Copy link
Owner

@skottler @evgeni Can you confirm this is resolved with 0.9.2?

@nesquena
Copy link
Owner

nesquena commented Dec 6, 2013

@skottler @evgeni I think this has been resolved. Please confirm on 0.9.2 or 0.9.3.pre1.

DouweM added a commit to DouweM/rabl that referenced this issue Oct 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants