Skip to content

BSON support provided through bson gem. #163

Merged
merged 1 commit into from Feb 12, 2012

4 participants

@Antiarchitect

Features:

  • no tests :trollface:
  • collection should always be wrapped into hash (implemented into to_bson) because of BSON.serialize accepts only hash.
@ognevsky
ognevsky commented Feb 9, 2012

I've tried add bson support to Rabl couple months ago, but something gone wrong.
Great work, thanks!

@olegbalbekov

+1

@nesquena
Owner
nesquena commented Feb 9, 2012

Sweet, great to have BSON support. If we can add something akin to https://github.com/nesquena/rabl/blob/master/test/msgpack_engine_test.rb for BSON, I will merge this and release a new gem version.

@Antiarchitect

I think I'll provide some tests soon - lack of time for today.

@nesquena
Owner
nesquena commented Feb 9, 2012

Awesome thanks for working on this.

@Antiarchitect Antiarchitect BSON format support provided. Fixed pluralization (without requiring …
…active_support/inflector it doesn't work in Rabl::Helpers). Covered by tests, results were compared with msgpack results and matches except for those that returns array - BSON.serialize can't accept arrays so it wraps it into a hash with first object name pluralization as a key.
b9ec72b
@Antiarchitect

I've just corrected my previous commit. Not it is covered by tests, bugs are fixed and it works as needed.

@nesquena nesquena merged commit f4aed40 into nesquena:master Feb 12, 2012
@nesquena
Owner

OK, added you to the readme, updated the changelog and pushed out 0.5.5.e. Let me know if everything looks OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.