Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BSON support provided through bson gem. #163

Merged
merged 1 commit into from
Feb 12, 2012
Merged

BSON support provided through bson gem. #163

merged 1 commit into from
Feb 12, 2012

Conversation

Antiarchitect
Copy link
Contributor

Features:

  • no tests :trollface:
  • collection should always be wrapped into hash (implemented into to_bson) because of BSON.serialize accepts only hash.

@ognevsky
Copy link
Contributor

ognevsky commented Feb 9, 2012

I've tried add bson support to Rabl couple months ago, but something gone wrong.
Great work, thanks!

@olegbalbekov
Copy link

+1

@nesquena
Copy link
Owner

nesquena commented Feb 9, 2012

Sweet, great to have BSON support. If we can add something akin to https://github.com/nesquena/rabl/blob/master/test/msgpack_engine_test.rb for BSON, I will merge this and release a new gem version.

@Antiarchitect
Copy link
Contributor Author

I think I'll provide some tests soon - lack of time for today.

@nesquena
Copy link
Owner

nesquena commented Feb 9, 2012

Awesome thanks for working on this.

@Antiarchitect
BSON format support provided. Fixed pluralization (without requiring …
b9ec72b 
…active_support/inflector it doesn't work in Rabl::Helpers). Covered by tests, results were compared with msgpack results and matches except for those that returns array - BSON.serialize can't accept arrays so it wraps it into a hash with first object name pluralization as a key.
@Antiarchitect
Copy link
Contributor Author

I've just corrected my previous commit. Not it is covered by tests, bugs are fixed and it works as needed.

nesquena added a commit that referenced this pull request Feb 12, 2012
@nesquena
Merge pull request #163 from Antiarchitect/master
f4aed40 
BSON support provided through bson gem.
@nesquena nesquena merged commit f4aed40 into nesquena:master Feb 12, 2012
@nesquena
Copy link
Owner

OK, added you to the readme, updated the changelog and pushed out 0.5.5.e. Let me know if everything looks OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Antiarchitect @ognevsky @olegbalbekov @nesquena