New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds optional msgpack serialization format to Rabl. #69

Merged
merged 1 commit into from Sep 2, 2011

Conversation

Projects
None yet
2 participants
@byu
Contributor

byu commented Jul 19, 2011

Details

  • Fixes #68 (nesquena/rabl issues tracker)
  • Message Pack: http://www.msgpack.org/
  • Defaults to using the Ruby msgpack gem: http://rubygems.org/gems/msgpack
  • Adds Rabl configuration option include_msgpack_root which has same semantics as include_json_root.
  • Adds Rabl configuration option msgpack_engine which has similar semantics as json_engine.
  • Adds whole test suite that is essentially a clone of engine_test.rb, but with proper msgpack expected values.
    Note that I converted the JSON expected values to their msgpack equivalent in this process.
  • Updated README.md to reflect the msgpack changes.
Adds optional msgpack serialization format to Rabl.
Details
* Fixes #68 (nesquena/rabl issues tracker)
* Message Pack: http://www.msgpack.org/
* Defaults to using the Ruby msgpack gem: http://rubygems.org/gems/msgpack
* Adds Rabl configuration option `include_msgpack_root` which has same semantics as include_json_root.
* Adds Rabl configuration option `msgpack_engine` which has similar semantics as json_engine.
* Adds whole test suite that is essentially a clone of engine_test.rb, but with proper msgpack expected values.
  Note that I converted the JSON expected values to their msgpack equivalent in this process.
* Updated README.md to reflect the msgpack changes.
@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Jul 19, 2011

Owner

Thanks will review and merge this in soon!

Owner

nesquena commented Jul 19, 2011

Thanks will review and merge this in soon!

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Sep 2, 2011

Owner

@byu Thanks for contributing this! Finally merging now

Owner

nesquena commented Sep 2, 2011

@byu Thanks for contributing this! Finally merging now

nesquena added a commit that referenced this pull request Sep 2, 2011

Merge pull request #69 from byu/feature/msgpack
Adds optional msgpack serialization format to Rabl.

@nesquena nesquena merged commit 4462ea8 into nesquena:master Sep 2, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment