Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ness doesn't seem to pickup AWS credentials #156

Closed
rushi opened this issue Jun 14, 2021 · 11 comments
Closed

Ness doesn't seem to pickup AWS credentials #156

rushi opened this issue Jun 14, 2021 · 11 comments
Labels

Comments

@rushi
Copy link

rushi commented Jun 14, 2021

Ness can't seem to pick up the AWS credentials that are already configured in ~/.aws/credentials The credentials are correct since I verified it by using aws on my terminal. My user is an IAM user with full privileges.

○ npx ness deploy --domain demo.mydomain.com --dir dist --spa

Please provide your AWS credentials
Where can I find these?

🔑 AWS_ACCESS_KEY_ID:
🤐 AWS_SECRET_ACCESS_KEY:

After trying to find credentials when it prompts me for the credentials, I put in my valid access & secret keys, but it's still prompting me the same info over and over again.

I've tested this with Node v12 & v14

@adamdottv
Copy link
Collaborator

Hi @rushi! Thanks for trying out Ness. Can you tell me which OS you're running this on?

@wuwuwu
Copy link

wuwuwu commented Jun 14, 2021

Same here. MacOs Big Sur 11.4

@laurasac
Copy link

Same problem. Ubuntu 20.10

@adamdottv
Copy link
Collaborator

@rushi @wuwuwu @laurasac any of you mind to tell me how you install Node? Standalone installer? NVM? Something else?

@wuwuwu
Copy link

wuwuwu commented Jun 16, 2021

Nvm indeed

@laurasac
Copy link

with apt install

@rezaep
Copy link

rezaep commented Jun 18, 2021

Same here.
OS: Manjaro 21.0.7
Installation type: pacman -S npm
AWS credentials location: ~/.aws/config

@rushi
Copy link
Author

rushi commented Jun 26, 2021

@rushi @wuwuwu @laurasac any of you mind to tell me how you install Node? Standalone installer? NVM? Something else?

I use nvm to install my node

@adamdottv
Copy link
Collaborator

I'm still looking into this. If I can't reproduce I may just rework the credentials lookup as this seems fairly widespread.

adamdottv pushed a commit that referenced this issue Aug 9, 2021
## [1.7.3](v1.7.2...v1.7.3) (2021-08-09)

### Bug Fixes

* credential lookup fails if no .git is present ([09dd5ba](09dd5ba)), closes [#156](#156)
@adamdottv
Copy link
Collaborator

🎉 This issue has been resolved in version 1.7.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@adamdottv
Copy link
Collaborator

@rushi @wuwuwu @laurasac I believe this issue is fixed now. I name the CloudFormation stack with an ID that includes the git branch name of the repository, but I didn't realize that the tool I was using to grab the git branch throws when used in a non-git directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants