Build fail with no implicit any

[rafaelbatistamarcilio]

Hello people,

I don't know if this was because i update the mailer module, but the following error is happening when try to run or execute the production build.

If I disable the noImplicitAny flag in tsconfig.json, everything works fine.

My tsconfig.json

{
  "compilerOptions": {
    "module": "commonjs",
    "removeComments": true,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "target": "es2017",
    "sourceMap": true,
    "outDir": "./dist",
    "baseUrl": "./",
    "incremental": true,
    "noImplicitAny": true,
    "noImplicitReturns": false,
    "noUnusedParameters": false,
    "paths": {
      "@atividades/*": [ "./src/academico/atividades/*", ],
      "@documentos/*": [ "./src/academico/documentos/*"],
      "@config/*": [ "./src/config/*"],
      "@utils": [ "./src/utils"]
    }
  },
  "exclude": ["node_modules", "dist"]
}

I note that mailer module don't have a .d.ts file, this can be the reason of the error ?

[rafaelbatistamarcilio]

I just create an index.d.ts on the @nest-modules/mailer directory and everything works fine.

Inside the @nest-modules/mailer/dist exists some definition files. The index.d.ts file is in the wrong directory (@nest-modules/mailer/dist/index.d.ts)?

[rafaelbatistamarcilio]

Another definition error in ISendMailOptions, template option is not recognized

The ISendMailOptions interface is extending SendMailOptions. It doesn't have to extend MailerSendMailOptions?

I changed the heritage and everything works fine.

If that changes are correct can i open an PR ? 😃

[juandav]

PR please

[rafaelbatistamarcilio]

@juandav that's my first contribution for an open source project, any tips about commit messages, branch names, etc are very welcome! Thanks a lot for the opportunity of contribute with the project.

[juandav]

thank you.