Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sendMail options errors #85

Closed
yanarp opened this issue Mar 18, 2020 · 7 comments
Closed

sendMail options errors #85

yanarp opened this issue Mar 18, 2020 · 7 comments
Labels
bug Something isn't working

Comments

@yanarp
Copy link
Contributor

yanarp commented Mar 18, 2020

I believe the latest version, have somewhat didn't included the sendMail configuration in the send-mail-options-interface.ts
@juandav
Copy link
Member

juandav commented Mar 18, 2020

what is the error

@yanarp
Copy link
Contributor Author

yanarp commented Mar 19, 2020

Argument of type is not assignable to parameter of type ISendMailOptions

@day1309
Copy link

day1309 commented Mar 19, 2020

I have the same error.. searching i found it on previous issues report, but it repeat now.
Argument of type is not assignable to parameter of type 'ISendMailOptions' #25

@yanarp
Copy link
Contributor Author

yanarp commented Mar 19, 2020

I'm sure this is a easy fix, cause we had a stable version of this, earlier, so prolly we gonna get the stable version again

@day1309
Copy link

day1309 commented Mar 19, 2020

Yes, im sure.. I fix it updating ISendMailOptions on node_modules package but it is not the best solutions
image

@yanarp
Copy link
Contributor Author

yanarp commented Mar 19, 2020

Nah, that won't do for everyone isn't. Let's wait, I'm sure will get it properly via a release !

@yanarp
Copy link
Contributor Author

yanarp commented Mar 19, 2020

Or else you can go back to v1.3.6 I'm sure it will be working fine, I have it running in my old projects.

juandav added a commit that referenced this issue Mar 19, 2020
@juandav
fix(): sendMail options errors #85
02e5950
@juandav juandav added the bug Something isn't working label Mar 19, 2020
@juandav juandav closed this as completed Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yanarp @juandav @day1309