Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register all dependencies for examples with EBRAINS software releases #2650

Open
terhorstd opened this issue Mar 23, 2023 · 3 comments
Open
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Bug Wrong statements in the code or documentation

Comments

@terhorstd
Copy link
Contributor

terhorstd commented Mar 23, 2023

Is your feature request related to a problem? Please describe.
The running in notebooks page doc/htmldoc/examples/running_notebooks.rst currently states that one should install package via pip. These are untracked dependendencies and may be updated unnoticed, breaking any such example.

Describe the solution you'd like
All package dependencies for the examples should be explicitly tracked to allow for stable global dependency resolution.

Please bring any pip install requirement to my attention or the installation team by commenting in this issue.

@terhorstd terhorstd added T: Bug Wrong statements in the code or documentation S: Normal Handle this with default priority I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Mar 23, 2023
@terhorstd terhorstd added this to To do in Installation via automation Mar 23, 2023
@terhorstd terhorstd added this to To do in Documentation via automation Mar 23, 2023
@github-actions
Copy link

Issue automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label May 23, 2023
@terhorstd
Copy link
Contributor Author

This is related to the issues seen in #2834. The additional dependencies of NEST usage examples are not actually NEST dependencies and shouldn't bloat NEST-only installs. It is not yet clear if these should be doc dependencies or test dependencies, or a separate category.

@github-actions github-actions bot removed the stale Automatic marker for inactivity, please have another look here label Dec 14, 2023
Copy link

Issue automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Bug Wrong statements in the code or documentation
Projects
Documentation
  
To do
Installation
  
To do
Development

No branches or pull requests

1 participant